Re: [PATCH 1/7] LinuxPPS core support.

[Kay Sievers]

On Thu, Mar 6, 2008 at 1:09 PM, Rodolfo Giometti <giometti@xxxxxxxx> wrote:
> This patch adds the kernel side of the PPS support currently named
>  "LinuxPPS".

>  diff --git a/drivers/pps/sysfs.c b/drivers/pps/sysfs.c
>  new file mode 100644
>  index 0000000..c25c91c
>  --- /dev/null
>  +++ b/drivers/pps/sysfs.c
>  @@ -0,0 +1,130 @@

>  +void pps_sysfs_remove_source_entry(struct pps_device *pps)
>  +{
>  +       /* Delete info files */
>  +       sysfs_remove_group(&pps->dev->kobj, &pps_group);
>  +}
>  +
>  +int pps_sysfs_create_source_entry(struct pps_device *pps)
>  +{
>  +       int ret;
>  +
>  +       /* Create info files */
>  +       ret = sysfs_create_group(&pps->dev->kobj, &pps_group);

Any specific reason you are creating the group by hand, and not assign
it to the default group in your class? It would will let the core
handle it for you. The device add uevent to userspace will happen
before you added the attributes, which is usually not nice.

Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/