Re: [patch] forcedeth: fix locking bug with netconsole

From: Jeff Garzik
Date: Fri Mar 21 2008 - 12:10:31 EST


Ingo Molnar wrote:
Subject: forcedeth: fix locking bug with netconsole
From: Ingo Molnar <mingo@xxxxxxx>

while using netconsole on forcedeth, lockdep noticed the following
locking bug:
[...]
the fix is to disable/restore irqs instead of disable/enable.

So we make _the_ TX fast path slower, to accomodate a path that is rarely executed?

That seems like the wrong fix to me.

Jeff



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/