Re: [patch 07/76] NIU: Bump driver version and release date.

[David Miller]

From: David Miller <davem@xxxxxxxxxxxxx>
Date: Fri, 21 Mar 2008 22:21:25 -0700 (PDT)

> From: Roland Dreier <rdreier@xxxxxxxxx>
> Date: Fri, 21 Mar 2008 19:35:40 -0700
> 
> >  > It makes a difference for driver maintainers when users
> >  > report bugs and we ask them for the version printed
> >  > by the driver so that we know which fixes have been
> >  > applied.
> > 
> > I'm not sure if this series of patches really accomplishes that...
> > you're leaving out some patches such as "[NIU]: Fix 1G PHY link state
> > handling." that are in the real 0.7.  So the 2.6.24.stable version 0.7
> > has a different set of fixes than the 2.6.25 version 0.7.
> 
> That was an oversight and not intentional, thanks for
> for catching that.

Actually Roland, that 1G fix you mention was put in during the
2.6.23 development series.

If you ask git for all the NIU driver changes since 2.6.24
you get:

davem@sunset:~/src/GIT/linux-2.6$ git log v2.6.24.. drivers/net/niu.[ch]
commit fa907895b7b776208a1406efe5ba7ffe0f49f507
Author: Matheos Worku <Matheos.Worku@xxxxxxx>
Date:   Wed Feb 20 00:18:09 2008 -0800

    [NIU]: More BMAC alt MAC address fixes.
    
    From: Matheos Worku <Matheos.Worku@xxxxxxx>
    
    1) niu_enable_alt_mac() needs to be adjusted so that the mask
       is computed properly for the BMAC case.
    
    2) BMAC has 6 alt MAC addresses available, not 7.
    
    Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>

commit a442585952f137bd4cdb1f2f3166e4157d383b82
Author: David S. Miller <davem@xxxxxxxxxxxxx>
Date:   Mon Feb 18 21:30:48 2008 -0800

    [NIU]: Bump driver version and release date.
    
    Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>

commit 3b5bcedeeb755b6e813537fcf4c32f010b490aef
Author: Matheos Worku <matheos.worku@xxxxxxx>
Date:   Mon Feb 18 21:30:03 2008 -0800

    [NIU]: Fix BMAC alternate MAC address indexing.
    
    BMAC port alternate MAC address index needs to start at 1. Index 0 is
    used for the main MAC address.
    
    Signed-off-by: Matheos Worku <matheos.worku@xxxxxxx>
    Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>

commit 2caf62f6cae46e36b1c4a1b0f2d9ef82af89cad2
Author: Joe Perches <joe@xxxxxxxxxxx>
Date:   Thu Dec 20 04:07:35 2007 -0800

    [NIU]: Use print_mac
    
    Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
    Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
davem@sunset:~/src/GIT/linux-2.6$ 

Since using print_mac is a one-liner cleanup rather than a bug fix,
it's reasonable to leave it out for 2.6.24-stable

What's left is exactly what I submitted for -stable.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/