Re: [RT] [PATCH] Make scheduler root_domain modular(sched_classspecific)

[Peter Zijlstra]

On Sun, 2008-03-23 at 17:07 +0530, Ankita Garg wrote:
> Hi Peter,
> 
> On Sun, Mar 23, 2008 at 12:27:07PM +0100, Peter Zijlstra wrote:
> > On Sun, 2008-03-23 at 14:32 +0530, Ankita Garg wrote:
> > > Hi Gregory,
> > > 
> > > On Sat, Mar 22, 2008 at 12:04:04PM -0600, Gregory Haskins wrote:
> > > > >>> On Sat, Mar 22, 2008 at 10:29 AM, in message
> > > > <20080322142915.GA9478@xxxxxxxxxx>, Ankita Garg <ankita@xxxxxxxxxx> wrote: 
> > > > > Hello,
> > > > > 
> > > > > Thanks Gregory for clarifying my question on root_domains infrastructure. 
> > > > > What
> > > > > I was effectively mentioning on irc the other day was to make the 
> > > > > root_domain
> > > > > infrastructure modular, ie sched_class specific. Currently, only rt is 
> > > > > making
> > > > > use of this infrasture. Making it modular would enable ease of extension to
> > > > > other sched_classes if required. Trivial patch to that effect.
> > > > > 
> > > > > Patch compile and boot tested.
> > > > 
> > > > Hi Ankita,
> > > >   Very nice, thanks!  Couple of minor nits and further cleanup opportunities inline, but otherwise:
> > > >
> > > > Acked-by: Gregory Haskins <ghaskins@xxxxxxxxxx>
> > > > 
> > > > > 
> > > The changes you have suggested are consistent with what we do for rt_rq
> > > and cfs_rq. Here is the patch with these modifications.
> > 
> > As this patch doesn't touch -rt specific code you should have provided a
> > patch against the upstream code in sched-devel/latest.
> >
> 
> The cpupri bits have not been added to the sched-devel tree yet. This
> patch involves linking to the cpupri from the rt_root_domain. Thus  the
> patch against the latest RT tree. Pl let me know if I understand it
> incorrectly.

The root_domain code is upstream and not -rt specific, that -rt carries
a patch that touches this code is perhaps unfortunate.

We strive to keep the -rt patch as small as possible, that means push
stuff upstream whenever possible. As your patch doesn't change anything
specific to -rt, upstream is the right place to restructure the
root_domain code. Next time the -rt tree gets fwd ported the cpupri bits
will be made to match.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/