Re: [PATCH 2/2] time: xtime lock vs printk

[Daniel Walker]

On Mon, 2008-03-24 at 13:24 +0100, Peter Zijlstra wrote:
> -       printk(KERN_INFO "Time: %s clocksource has been installed.\n",
> +       /*
> +        * We're holding xtime lock and waking up klogd would deadlock
> +        * us on enqueue. Print without waking.
> +        */
> +       printk_nowakeup(KERN_INFO "Time: %s clocksource has been
> installed.\n",
>                clock->name);

It doesn't seem like there is a lot of potential for more xtime write
lock holders to do printk's .. We could just remove this line, or move
this printk into an __init ..

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/