Re: [PATCH] kbuild: silence documentation GEN xml messagesaccording to $(quiet)

From: Randy Dunlap
Date: Mon Mar 24 2008 - 12:10:26 EST


On Mon, 24 Mar 2008 11:16:55 -0400 Mike Frysinger wrote:

> Signed-off-by: Mike Frysinger <vapier@xxxxxxxxxx>
> ---
> Documentation/DocBook/Makefile | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/DocBook/Makefile b/Documentation/DocBook/Makefile
> index 300e170..f6a4ba3 100644
> --- a/Documentation/DocBook/Makefile
> +++ b/Documentation/DocBook/Makefile
> @@ -186,8 +186,11 @@ quiet_cmd_fig2png = FIG2PNG $@
>
> ###
> # Rule to convert a .c file to inline XML documentation
> + gen_xml = :
> + quiet_gen_xml = echo ' GEN $@'
> +silent_gen_xml = :
> %.xml: %.c
> - @echo ' GEN $@'
> + @$($(quiet)gen_xml)
> @( \
> echo "<programlisting>"; \
> expand --tabs=8 < $< | \
> --

The Makefile changes are good, but the patch description makes it
appear that Mike was rushed. How about something like this?

Add rules for gen_xml and its quiet & silent variants.
This causes "make -s" to be silent for gen_xml.

Acked-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>

---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/