Re: checkpatch [was: include/asm-x86/serial.h: checkpatch cleanups - formatting only]

From: Will Newton
Date: Mon Mar 24 2008 - 12:29:01 EST


On 23 Mar 2008 18:36:21 +0100, Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:

> Also checkpatch.pl --file seems to be a good candidate for one
> of the worst ideas ever merged (to be fair it was difficult
> to see it would become that bad in advance -- but it got)

I have found checkpatch --file useful when taking large amounts of out
of tree code (a kernel arch subdir and a number of drivers) and trying
to get them into better shape for inclusion. In that situation it's
quite a good way of seeing how far off that goal I am. Running it on
existing in-tree code is more problematic.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/