Re: [PATCH] 3/3 maple: update bus driver to support Dreamcast VMU

[Adrian McMenamin]

On Mon, 2008-03-24 at 18:07 +0100, JÃrn Engel wrote:
> On Mon, 24 March 2008 17:04:29 +0100, JÃrn Engel wrote:
> > 
> > Then we should be fine.  I'll try to beat the code into submission.
> 
> And here go two more interesting patches.  The first is removing all
> locking from the mtd driver.  Since the existing locking code is nearly
> impossibly to verify, I'd rather have something simple and wrong than
> something complicated and wrong.
> 
> The second rearranges the list locking a bit.  Previously it was
> possible to touch maple_waitq or maple_sentq without holding the lock.
> With my limited understanding of the driver, the second patch may
> already be enough to prevent the type of corruption you've been seeing.
> 
> JÃrn
> 


These will fail.

Removing the locks just about guarantees memory corruption and
maple_waitq is not the issue - it is the objects held in maple_waitq
that are the issue.

I have an idea though, so let me hack at it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/