Re: [PATCH] x86: enable PAT for amd k8 and fam10h

[H. Peter Anvin]

Yinghai Lu wrote:
> [PATCH] x86: enable PAT for amd k8 and fam10h
>
> make known_pat_cpu to think amd k8 and fam10h is ok too.
>
> also make tom2 below to be WRBACK
>
> diff --git a/arch/x86/mm/pat.c b/arch/x86/mm/pat.c
> index f74505f..a9e1a27 100644
> --- a/arch/x86/mm/pat.c
> +++ b/arch/x86/mm/pat.c
> @@ -49,6 +49,12 @@ static int pat_known_cpu(void)
>  			return 1;
>  		}
>  	}
> +	if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD &&
> +	     boot_cpu_data.x86 >= 0xf && boot_cpu_data.x86 <= 0x11) {
> +		if (cpu_has_pat) {
> +			return 1;
> +		}
> +	}
>  
>  	pat_wc_enabled = 0;
>  	printk(KERN_INFO "CPU and/or kernel does not support PAT.\n");

This really should be handled through a CPU flag.  Specifically, it 
should be handled by disabling the PAT flag if PAT is unusable or 
suspect of being unusable; it should *NOT* be stashed away in a 
completely separate piece of code.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/