Re: [PATCH] x86: PAT bug fix for attribute type check afterreserve_memtype

From: Ingo Molnar
Date: Tue Mar 25 2008 - 10:33:52 EST



* Venki Pallipadi <venkatesh.pallipadi@xxxxxxxxx> wrote:

> Bug fixes for reserve_memtype() call in __ioremap and
> pci_mmap_page_range(). If reserve_memtype returns non-zero, then it is
> an error and subsequent free is not required. Requested and returned
> prot value check should be done when reserve_memtype returns success.

thanks, applied.

> + if (retval) {
> + printk("reserve_memtype returned %d\n", retval);

that needs a KERN_INFO, and should be labeled "Warning: ...".

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/