RE: [patch 51/76] ioat: fix ack handling, driver must ensure that ack is zero

[Sosnowski, Maciej]

> ---------- Original message ----------
> From: Chris Wright <chrisw@xxxxxxxxxxxx>
> Date: Mar 21, 2008 11:43 PM
> Subject: [patch 51/76] ioat: fix ack handling, driver must ensure that
> ack is zero
> To: linux-kernel@xxxxxxxxxxxxxxx, stable@xxxxxxxxxx, jejb@xxxxxxxxxx
> Cc: Justin Forbes <jmforbes@xxxxxxxxxxx>, Zwane Mwaikambo
> <zwane@xxxxxxxxxxxxxxxx>, Theodore Ts'o <tytso@xxxxxxx>, Randy Dunlap
> <rdunlap@xxxxxxxxxxxx>, Dave Jones <davej@xxxxxxxxxx>, Chuck Wolber
> <chuckw@xxxxxxxxxxxxxxxx>, Chris Wedgwood <reviews@xxxxxxxxxxxxxx>,
> Michael Krufky <mkrufky@xxxxxxxxxxx>, Chuck Ebbert
> <cebbert@xxxxxxxxxx>, Domenico Andreoli <cavokz@xxxxxxxxx>,
> torvalds@xxxxxxxxxxxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx,
> alan@xxxxxxxxxxxxxxxxxxx, Dan Williams <dan.j.williams@xxxxxxxxx>,
> Shannon Nelson <shannon.nelson@xxxxxxxxx>, Greg Kroah-Hartman
> <gregkh@xxxxxxx>
> 
> 
> -stable review patch.  If anyone has any objections, please let us
know.
> ---------------------
> 
> From: Dan Williams <dan.j.williams@xxxxxxxxx>
> 
> Initialize 'ack' to zero in case the descriptor has been recycled.
> 
> Prevents "kernel BUG at crypto/async_tx/async_xor.c:185!"
> 
> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> Acked-by: Shannon Nelson <shannon.nelson@xxxxxxxxx>
> [chrisw@xxxxxxxxxxxx: backport to 2.6.24.3]
> Signed-off-by: Chris Wright <chrisw@xxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> ---
> 
>  drivers/dma/ioat_dma.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- a/drivers/dma/ioat_dma.c
> +++ b/drivers/dma/ioat_dma.c
> @@ -726,6 +726,7 @@ static struct dma_async_tx_descriptor *i
> 
>        if (new) {
>                new->len = len;
> +               new->async_tx.ack = 0;
>                return &new->async_tx;
>        } else
>                return NULL;
> @@ -749,6 +750,7 @@ static struct dma_async_tx_descriptor *i
> 
>        if (new) {
>                new->len = len;
> +               new->async_tx.ack = 0;
>                return &new->async_tx;
>        } else
>                return NULL;
> 
> --

Acked-by: Maciej Sosnowski <maciej.sosnowski@xxxxxxxxx>
---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
z siedziba w Gdansku
ul. Slowackiego 173
80-298 Gdansk

Sad Rejonowy Gdansk Polnoc w Gdansku, 
VII Wydzial Gospodarczy Krajowego Rejestru Sadowego, 
numer KRS 101882

NIP 957-07-52-316
Kapital zakladowy 200.000 zl

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/