Re: [Linux-fbdev-devel] [PATCH 1/2] Blackfin Video Driver: Updatethe BF52x EZKIT video framebuffer driver according to LKML review

[Geert Uytterhoeven]

On Wed, 26 Mar 2008, Bryan Wu wrote:
> @@ -552,11 +544,11 @@ static int __init bfin_t350mcqb_probe(struct platform_device *pdev)
>  		goto out7;
>  	}
>  
> -	if (request_irq(info->irq, (void *)bfin_t350mcqb_irq_error, IRQF_DISABLED,
> -			"PPI ERROR", info) < 0) {
> +	ret = request_irq(info->irq, (void *)bfin_t350mcqb_irq_error, IRQF_DISABLED,
                                     ^^^^^^^^
This cast should not be necessary. If it is, the signature of
bfin_t350mcqb_irq_error() is incorrect.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/