Re: [PATCH 00/12] cpumask: reduce stack pressure from local/passedcpumask variables v2

From: Mike Travis
Date: Wed Mar 26 2008 - 11:53:43 EST


Ingo Molnar wrote:
> * Mike Travis <travis@xxxxxxx> wrote:
>
>> Modify usage of cpumask_t variables to use pointers as much as
>> possible.
>
> hm, why is there no minimal patch against -git that does nothing but
> introduces the new pointer based generic APIs (without using them) -
> such as set_cpus_allowed_ptr(), etc.? Once that is upstream all the
> remaining changes can trickle one arch and one subsystem at a time, and
> once that's done, the old set_cpus_allowed() can be removed. This is far
> more manageable than one large patch.
>
> and the cpumask_of_cpu() change should be Kconfig based initially - once
> all arches have moved to it (or even sooner) we can remove that.
>
> Ingo

Yes, good idea! I'll see about dividing them up. Though 99% seems to
be in generic kernel code (kernel/sched.c is by far the biggest user.)

There is one function pointer in a struct that would need an additional entry
if we keep both interfaces.

Thanks,
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/