Re: [PATCH 06/10] x86: reduce memory and stack usage in intel_cacheinfo

From: Jeremy Fitzhardinge
Date: Wed Mar 26 2008 - 12:59:23 EST


Mike Travis wrote:
Hmm, I hadn't thought of that. There is commonly a format spec called
%b for diags, etc. to print bit strings. Maybe something like:

"... %*b ...", nr_cpu_ids, ptr_to_bitmap

where the length arg is rounded up to 32 or 64 bits...?

I think that would need to be %.*b, but I always need to try it both ways anyway...

But yes, that seems like the right way to go.

Eh? What's the difference between snprintf and scnprintf?

Good question... I'll have to ask the cpumask person. ;-)

It's in generic lib/vsprintf.c. The two functions are pretty much identical... Oh, I see; snprintf returns the total output size, regardless of whether it fits into the provided buffer, but scnprintf returns the actual output size, clipped by the buffer length.

J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/