Re: [patch] pci: revert "PCI: remove transparent bridge sizing"

[Gary Hade]

On Wed, Mar 26, 2008 at 02:54:58PM +0100, Ingo Molnar wrote:
> 
> * Ivan Kokshaysky <ink@xxxxxxxxxxxxxxxxxxxx> wrote:
> 
> > Thomas, can you put CONFIG_RESOURCES_64BIT=y back and either revert 
> > commit 8fa5913d54f3b1e09948e6a0db34da887e05ff1f, or just comment out 
> > these two lines in drivers/pci/setup-bus.c:
> > 
> > 		if (bus->self->transparent)
> > 			break;
> > 
> > and check if it helps?
> 
> alternatively, try x86.git/latest which has the revert below included.

As the author of the "PCI: remove transparent bridge sizing" change,
I apologize for the trouble it seems to have caused.  The same change
had also exposed an issue reported by Paul Martin that has been causing
an Oops while hotplugging ThinkPads to a ThinkPad Dock II.
 re: http://lkml.org/lkml/2008/2/19/405
     http://bugzilla.kernel.org/show_bug.cgi?id=9961
I have a fix for the ThinkPad docking Oops but if the issue being
discussed here is caused by the transparent bridge sizing removal
change I totally agree that it should be reverted.  

The transparent bridge sizing removal change was motivated by
insufficient PCI memory resource for a transparent bridge window
that was being created as a result of expansion ROM(s) being included
in the transparent bridge sizing calculations.  A later
"PCI: Remove default PCI expansion ROM memory allocation" change
( re: http://lkml.org/lkml/2007/12/11/361 ) removes the expansion
ROM(s) from the transparent bridge sizing calculations which actually
resolves the original issue in a different manner.  So, even if the
"PCI: remove transparent bridge sizing" is not problematic it is
no longer needed anyway.

Gary

-- 
Gary Hade
System x Enablement
IBM Linux Technology Center
503-578-4503  IBM T/L: 775-4503
garyhade@xxxxxxxxxx
http://www.ibm.com/linux/ltc

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/