Re: [PATCH 06/10] x86: reduce memory and stack usage in intel_cacheinfo

From: Mike Travis
Date: Wed Mar 26 2008 - 14:15:25 EST


Jeremy Fitzhardinge wrote:
> Mike Travis wrote:
>> Hmm, I hadn't thought of that. There is commonly a format spec called
>> %b for diags, etc. to print bit strings. Maybe something like:
>>
>> "... %*b ...", nr_cpu_ids, ptr_to_bitmap
>>
>> where the length arg is rounded up to 32 or 64 bits...?
>
> I think that would need to be %.*b, but I always need to try it both
> ways anyway...
>
> But yes, that seems like the right way to go.

I had the same thought after hitting return.

But for this case, I was over thinking the problem. Turns out that the
number of cpus in a leaf will be fairly small, even with new cpus around
the corner (maybe 64 or 128 cpu threads per leaf?)

So I dropped the cpumask_scnprintf_len() patch and have a new intel_cacheinfo
patch which I'll send in a separate message.

Thanks,
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/