Re: [patch] pci: revert "PCI: remove transparent bridge sizing"

From: Ingo Molnar
Date: Wed Mar 26 2008 - 17:31:32 EST



* Gary Hade <garyhade@xxxxxxxxxx> wrote:

> On Wed, Mar 26, 2008 at 02:54:58PM +0100, Ingo Molnar wrote:
> >
> > * Ivan Kokshaysky <ink@xxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > > Thomas, can you put CONFIG_RESOURCES_64BIT=y back and either revert
> > > commit 8fa5913d54f3b1e09948e6a0db34da887e05ff1f, or just comment out
> > > these two lines in drivers/pci/setup-bus.c:
> > >
> > > if (bus->self->transparent)
> > > break;
> > >
> > > and check if it helps?
> >
> > alternatively, try x86.git/latest which has the revert below included.
>
> As the author of the "PCI: remove transparent bridge sizing" change, I
> apologize for the trouble it seems to have caused. [...]

no need to apologize, bugs happen. Could we perhaps add a WARN_ON()
somewhere to detect the nonsensical (for that particular hardware)
resource setup?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/