Re: iommu breaks usb after resume

From: Pavel Machek
Date: Wed Mar 26 2008 - 19:04:30 EST


On Thu 2008-03-27 00:00:17, Ingo Molnar wrote:
>
> * Pavel Machek <pavel@xxxxxx> wrote:
>
> > @@ -733,8 +735,8 @@ static struct pci_driver agp_amd64_pci_d
> > .probe = agp_amd64_probe,
> > .remove = agp_amd64_remove,
> > #ifdef CONFIG_PM
> > - .suspend = agp_amd64_suspend,
> > - .resume = agp_amd64_resume,
> > + .suspend_late = agp_amd64_suspend,
> > + .resume_early = agp_amd64_resume,
> > #endif
>
> ah, makes sense. I've queued up your fix in x86.git (sans the debug
> printks), please send your signoff once you can verify that it solves
> the hibernation hang on your box and we'll push it into 2.6.25.

I've not even compiled it. It is obviously

Signed-off-by: Pavel Machek <pavel@xxxxxxx>

(it is GPLed) ...but it is totally untested, and probably same fix
needs to go to all the agp drivers...?

I'll test it tommorow.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
pomozte zachranit klanovicky les: http://www.ujezdskystrom.info/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/