Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend andhibernation callbacks (rev. 4)

[Alan Stern]

On Thu, 27 Mar 2008, Rafael J. Wysocki wrote:

> @@ -68,22 +75,32 @@ int device_pm_add(struct device *dev)
>  		 dev->bus ? dev->bus->name : "No Bus",
>  		 kobject_name(&dev->kobj));
>  	mutex_lock(&dpm_list_mtx);
> -	if ((dev->parent && dev->parent->power.sleeping) || all_sleeping) {
> -		if (dev->parent->power.sleeping)
> -			dev_warn(dev,
> -				"parent %s is sleeping, will not add\n",
> +	if (dev->parent) {
> +		if (dev->parent->power.status >= DPM_SUSPENDING) {
> +			dev_warn(dev, "parent %s is sleeping, will not add\n",
>  				dev->parent->bus_id);

You forgot to check for dev->parent->power.status == DPM_INVALID.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/