RE: [patch] x86, ptrace: support pebs in ds.c and disableptraceand ds support

[Metzger, Markus T]

>-----Original Message-----
>From: Ingo Molnar [mailto:mingo@xxxxxxx] 
>Sent: Donnerstag, 27. März 2008 10:58
>To: Metzger, Markus T

Ingo,

Thanks for your comments.


>> The patch is not adding new features. It is merely 
>re-establishing the 
>> state before the patch mysteriously disappeared from x86#testing.
>
>well, Roland is the de-facto ptrace maintainer and he has NAK-ed the 
>current approach of extending ptrace, so i removed the patch. Is there 
>anything particularly wrong about doing this based on utrace? The API 
>will hit upstream in 2.6.26 or 2.6.27.

There is nothing wrong with a utrace interface.

It's just that if I want to enable existing debuggers, I need to offer ptrace, as well - at least until utrace is widely used. The intel debugger, for example, will not speak utrace for the next version; but it would support execution tracing, if it were available.


Regarding the patch, it merely restructures the existing (and still present) implementation and adds support for PEBS so Stephane can use this as the low-level interface.

It does not invent any new ptrace commands (although it changes bits in an existing ptrace command).

The patch further allows the ptrace and ds parts to be completely disabled - including all changes to context switching or task destruction (requested by Roland).

I think it is a definite improvement over what we have today.


regards,
markus.
---------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen Germany
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 Ust.-IdNr.
VAT Registration No.: DE129385895
Citibank Frankfurt (BLZ 502 109 00) 600119052

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/