Re: iommu breaks usb after resume

From: Pavel Machek
Date: Thu Mar 27 2008 - 07:37:57 EST


Hi!

> > * Pavel Machek <pavel@xxxxxx> wrote:
> >
> > > @@ -733,8 +735,8 @@ static struct pci_driver agp_amd64_pci_d
> > > .probe = agp_amd64_probe,
> > > .remove = agp_amd64_remove,
> > > #ifdef CONFIG_PM
> > > - .suspend = agp_amd64_suspend,
> > > - .resume = agp_amd64_resume,
> > > + .suspend_late = agp_amd64_suspend,
> > > + .resume_early = agp_amd64_resume,
> > > #endif
> >
> > ah, makes sense. I've queued up your fix in x86.git (sans the debug
> > printks), please send your signoff once you can verify that it solves
> > the hibernation hang on your box and we'll push it into 2.6.25.
>
> You have my signed-off from previous email, but...
>
> it does not solve a problem here -- see the mail to andi. It may still
> be good idea to take it (but I do not think it should go to 2.6.25),
> but may machine still does not work.

No, I do not think problems are in drivers/char/agp...

end of aperture_64.c:

/* Fix up the north bridges */
for (num = 24; num < 32; num++) {
if (!early_is_k8_nb(read_pci_config(0, num, 3, 0x00)))
continue;

/*
* Don't enable translation yet. That is done later.
* Assume this BIOS didn't initialise the GART so
* just overwrite all previous bits
*/
write_pci_config(0, num, 3, 0x90, aper_order<<1);
write_pci_config(0, num, 3, 0x94, aper_alloc>>25);
}
}

...this sounds like it needs to be done during resume, too, no?

Where's the other part? "Don't enable translation yet"? What enables
the translation?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
pomozte zachranit klanovicky les: http://www.ujezdskystrom.info/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/