Re: [PATCH 2/3] EDAC Fix module initialization on several modules

From: Andrew Morton
Date: Thu Mar 27 2008 - 17:18:50 EST


On Wed, 19 Mar 2008 14:55:54 -0600
dougthompson@xxxxxxxxxxxx wrote:

> From: Hitoshi Mitake <h.mitake@xxxxxxxxx>
>
> I implmented opstate_init() as a inline function in linux/edac.h .
>
> added calling opstate_init() to:
> i82443bxgx_edac.c
> i82860_edac.c
> i82875p_edac.c and
> i82975x_edac.c .
>
> I think modified sources are now polling well.
>
> Hitoshi
>
> This is a good refactor to reduce the initialization code to a single
> point of implementaton, and then just call that code from each of the
> modules to setup proper state

I futzed around for a while getting this to build with i386
allmodconfig but then got a bit tired of it.

Version 2, please ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/