Re: [PATCH 3/7] [NET]: uninline dev_alloc_skb, de-bloats a lot

From: David Miller
Date: Thu Mar 27 2008 - 20:52:28 EST


From: Denys Vlasenko <vda.linux@xxxxxxxxxxxxxx>
Date: Fri, 28 Mar 2008 00:36:59 +0100

> Can you add a comment which explains the intent?
>
> +struct sk_buff *dev_alloc_skb(unsigned int length)
> +{
> + /* There is more code here than it seems:
> + * __dev_alloc_skb is an inline */
> + return __dev_alloc_skb(length, GFP_ATOMIC);
> +}
> +EXPORT_SYMBOL(dev_alloc_skb);

I've applied his patch already, if you want this comment
please submit the patch to add it and also please use
the correct formatting of the comment.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/