Re: [PATCH 2 of 4] hotplug-memory: adding non-section-alignedmemory is bad

From: KAMEZAWA Hiroyuki
Date: Fri Mar 28 2008 - 00:40:59 EST


On Thu, 27 Mar 2008 21:20:18 -0700
Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:
> > How about capturing online_page() by balloon ?
> >
>
> You're saying that using online_page() on each page on its own is not
> sufficient?
>
online_page() just remove PG_reserved flags and free it.
Not dealing with global data, like total pages, zonelist, etc.

> > ex.)
> > ==
> > call add_memory() to create mem_map
> > call online_pages() against the whole section. <=== call this without sysfs.
> > online_pages() do misc. jobs
> > call online_page() one by one (arch dependent) called by walk_memory_resource.
> > online_page() will finally call free_page(page).
> > <=========== Xen capture here.
> > Don't free onlined page and swallow them into baloon driver.
> > ==
> >
>
> I'm not sure what you mean by "capture" here. Do you mean a hook? I'd
> rather not have to put some Xen-specific hook in here.
>
ok.

> What would happen if I did online_pages(pfn, 1) on each page as I
> populate it?
>
I think (hope) it works well. But it seems no one tries to do that.

Thanks,
-Kame



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/