Re: v4l & compat_ioctl

From: Andi Kleen
Date: Fri Mar 28 2008 - 07:25:52 EST


Jiri Slaby <jirislaby@xxxxxxxxx> writes:

> wouldn't make sense to add v4l ioctls to ioctl_start
> (fs/compat_ioctl.c) table to allow i386 stuff such as skype to run
> video on x86_64?

Don't make it a question.

In general any ioctl in any driver runnable on any 64bit
architecture that has a 32bit compat layer should have compat
support. Not having it is a bug.

However the new standard way to do this is to not
add new stuff into compat_ioctl.c, but define ->compat_ioctl
entry points in the low level drivers (and ideally converted
them to ->unlocked_ioctl too while you're at it)

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/