style of function definitions (Re: [patch] bkl2mtd: cleanup)

From: Oleg Verych
Date: Sun Mar 30 2008 - 00:10:26 EST


Ingo Molnar @ Wed, 26 Mar 2008 12:10:21 +0100
>
> * Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>
[]
>> > -static int block2mtd_write(struct mtd_info *mtd, loff_t to, size_t len,
>> > +static int
>> > +block2mtd_write(struct mtd_info *mtd, loff_t to, size_t len,
>> > size_t *retlen, const u_char *buf)
>>
>> Again, why split it that way?
>
> these are really nuances, so unless you are interested in such nuances
> nowhere found in CodingStyle, stop reading here :-)

Nuances, or not, there are all kinds of stuff in Linux. Very small
journey from simple `grep` and trivial multi-line `sed` to a huge
discovery can be found here:

http://kernelnewbies.org/olecom#Function_definitions

No matter what coding style is, the winner is "linux-2.6/fs/xfs", and
i doubt anyone can fix that :)

Maybe meta-patching by `sed` scripts in `git`? Just kidding.
--
-o--=O`C
#oo'L O
<___=E M
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/