RE: [PATCH] fix the broken annotations in fsldma

[Zhang Wei]

Hi, 

> -----Original Message-----
> From: Al Viro [mailto:viro@xxxxxxxxxxxxxxxx] On Behalf Of Al Viro
> 
> On Sat, Mar 29, 2008 at 09:02:02AM -0500, Josh Boyer wrote:
> > On Sat, 2008-03-29 at 03:10 +0000, Al Viro wrote:
> > > a) every bitwise declaration will give a unique type; use 
> typedefs.
> > > b) no need to bother with the stuff pointed to by iomem 
> pointers, unless
> > > it's accessed directly.  noderef will force us to use 
> helpers anyway.
> 
> > Did you forget to do the s/u{32,64}/v{32,64}/ conversion for this
> > struct, or am I just a moron?
> 
> See (b) above.
> 

Do you mean if we do it with a known 'force' casting, we do not need the
compiler check's help?

Thanks!
Wei.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/