Re: [PATCH][RFC] Add default CPU topology information

From: Ingo Molnar
Date: Mon Mar 31 2008 - 08:36:28 EST



* Ben Hutchings <bhutchings@xxxxxxxxxxxxxx> wrote:

> Not all architectures and configurations define CPU topology information.
> This can result in an empty topology directory in sysfs, and requires
> in-kernel users to protect all uses with #ifdef - see
> <http://marc.info/?l=linux-netdev&m=120639033904472&w=2>.
>
> The documentation of CPU topology specifies what the defaults should be
> if only partial information is available from the hardware. So we can
> provide these defaults as a fallback.
>
> This patch:
>
> - Adds default definitions of the 4 topology macros to
> include/asm-generic/topology.h.
> - Changes include/asm-*/topology.h to include <asm-generic/topology.h>
> unconditionally.
> - Changes drivers/base/topology.c to use the topology macros unconditionally
> and to cope with definitions that aren't lvalues.
> - Updates documentation accordingly.
>
> Signed-off-by: Ben Hutchings <bhutchings@xxxxxxxxxxxxxx>

very nice - i suspect this would be a patch for -mm.

Acked-by: Ingo Molnar <mingo@xxxxxxx>

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/