Re: [PATCH 0/3 v5] dma: add dma_*map*_attrs() interfaces

From: akepner
Date: Mon Mar 31 2008 - 21:33:41 EST


On Thu, Mar 27, 2008 at 08:18:43PM -0700, Andrew Morton wrote:
> On Wed, 19 Mar 2008 18:07:09 -0700 akepner@xxxxxxx wrote:
>
> alpha allmodconfig:
>
>
> In file included from include/asm/pci.h:7,
> from include/linux/pci.h:953,
> from include/asm/core_mcpcia.h:9,
> from include/asm/io.h:226,
> from arch/alpha/kernel/asm-offsets.c:11:
> include/linux/dma-mapping.h: In function 'dma_map_single_attrs':
> include/linux/dma-mapping.h:157: error: implicit declaration of function 'pci_map_single'
> ....
>
> We're in include hell, I think....

Yeah.

Alpha did some macro substitutions differently than on the
other platforms I had built and tested with.

The simple fix is to convert the new _attrs()* functions
in include/linux/dma-mapping.h into macros.

An updated patch follows. Built for alpha, ia64, x86_64.
Tested on ia64 and x86_64.

--
Arthur

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/