Re: usb-storage, error reading the last 8 sectors, regression in2.6.25-rc7

[Boaz Harrosh]

On Tue, Apr 01 2008 at 18:53 +0300, Matthew Dharm <mdharm-kernel@xxxxxxxxxxxxxxxxxx> wrote:
> On Tue, Apr 01, 2008 at 10:42:51AM -0400, Alan Stern wrote:
>> On Tue, 1 Apr 2008, Matthew Dharm wrote:
>>
>>> On Tue, Apr 01, 2008 at 10:28:52AM -0400, Alan Stern wrote:
>>>> On Tue, 1 Apr 2008, Oliver Neukum wrote:
>>>>
>>>>> Am Dienstag, 1. April 2008 03:58:31 schrieb Alan Stern:
>>>>>> Nevertheless, it's clear that the problem has nothing to do with the 
>>>>>> USB stack.  The real source of the problem lies in the device itself, 
>>>>>> for reporting a bogus error when in fact nothing went wrong.  That may 
>>>>>> also explain why you don't always see the problem -- sometimes the 
>>>>>> device works the way it ought to.
>>>>> Reminds me of the devices that can read the last sector but only if it is read
>>>>> by itself. Do you reckon this device may have the "opposite" quirk?
>>>> Could be something like that.
>>> Didn't I see some SCSI patches go by to implement exactly this change?
>>> That is, only read the last sector by itself?
>> You are getting the two problems mixed up.  The older problem, which
>> the SCSI patche addressed, was that the device would fail when
>> accessing the last sector unless the transfer was 1 sector long.
>>
>> This problem is different.  When performing an 8-sector read that 
>> includes the last sector, the device succeeds.  When performing a 
>> 7-sector read starting from the same place (so not including the last 
>> sector), the device fails.
> 
> I thought the patch I saw unconditionally re-wrote any access that included
> the last sector into two accesses -- everything but the last sector, and
> the last sector.
> 
> In other words, the patch attempted to avoid problems on devices that
> couldn't access the last sector unless the transfer was 1 sector long by
> ONLY accessing the last sector in a single transfer.
> 
> If I'm remembering correctly, that would explain the behavior change which
> lead to the exposure of the bad behavior of this new device.  This new
> device worked with the old code, but not with the new code.
> 
> Basically, by avoiding a common error condition in device firmware, we've
> found a device that has exactly the opposite bug.
> 
> Presuming someone can find the patch in the archive, reverting it would
> produce a good test case; it should restore this device to a working state.
> Maybe we need some auto-detect logic here; try the new way, if it fails,
> revert to the old behavior.  That's probably the safe order, as a lot of
> the devices with the more 'classic' bug just die completely, whereas this
> one appears to be recoverable.
> 
> Matt
> 

The old way was not necessarily correct for this type of device bug. Only
that it had a very high chance of not appearing.

When discussing the last bug, it was said to enable it by default for USB
instead of using blacklists. It looks like this bug, or the other, needs a
blacklist.

But to me it looks like this is a 4k thing. I think Windows will always
use 4k for FAT, though never triggering either of the bugs.

The one submitting the last sector patch was, I think, Hans de Goede (CCed)
Hans ?
  If I read last 8 sectors (4k) on a device that exhibits the "last sector bug"
  Does it work? (Is 8 a magic number here)

Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/