Re: [RFC][PATCH] PM: Introduce new top level suspend andhibernation callbacks (rev. 6)

[Nigel Cunningham]

Hi Rafael etc.

On Tue, 2008-04-01 at 22:12 +0200, Rafael J. Wysocki wrote:
> 'ext' means 'extended'.  The idea is that the 'extended' version will be used
> by bus types / driver types that don't need to implement the _noirq callbacks.
> Both the platform and PCI bus types generally allow drivers to use _noirq
> callbacks, so they use 'struct pm_ext_ops', as well as their corresponding
> driver types.

Do you mean to say in the first sentence "...that _do_ need to
implement..."? If not, then extended sounds like a misnomer and the two
sentences seem to contradict one another.

[...]

> > > + *	However, drivers may NOT assume anything about the availability of the
> > > + *	user space at that time and it is not correct to request firmware from
> > > + *	within @prepare() (it's too late to do that).
> > 
> > That doesn't sound good. It would be good to be able to get drivers to
> > request firmware early in the process.
> 
> That will be possible when we drop the freezer.

Yeah, but right now, it seems to me to be a bogus limitation for drivers
to have no way of automatically loading firmware when you're about to
hibernate. (Of course I've since been reminded of the notifier chain -
that should probably be mentioned here as the way of achieving this).

By the way, I'm going to go on record now as saying I think dropping the
freezer is a silly idea. I'm therefore currently considering including
the freezer in TuxOnice from the time it gets dropped from mainline. I
know that will only make it less likely that TuxOnIce gets merged, but
I've given up caring about that anyway - caring about merging is
pointless when the people who decide if it gets merged don't care.

Regards,

Nigel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/