Re: [PATCH 1/2] Keep track of original clocksource frequency

From: John Stultz
Date: Wed Apr 02 2008 - 11:38:49 EST



On Wed, 2008-04-02 at 13:20 +0200, Roman Zippel wrote:
> Hi,
>
> On Tue, 18 Mar 2008, john stultz wrote:
>
> > @@ -63,6 +64,7 @@ struct clocksource {
> > cycle_t (*read)(void);
> > cycle_t mask;
> > u32 mult;
> > + s32 mult_orig;
> > u32 shift;
> > unsigned long flags;
> > cycle_t (*vread)(void);
>
> This is wrong, with HZ=100 the jiffies clock multiplier suddenly becomes
> negative and later the raw interval underflows.

Ah, thanks for catching that!

>
> Signed-off-by: Roman Zippel <zippel@xxxxxxxxxxxxxx>

Acked-by: John Stultz <johnstul@xxxxxxxxxx>



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/