Re: [PATCH] iwlwifi/Kconfg: make IWLWIFI_LEDS invisible
From: Tomas Winkler
Date: Wed Apr 02 2008 - 16:18:05 EST
On Wed, Apr 2, 2008 at 7:10 PM, John W. Linville <linville@xxxxxxxxxxxxx> wrote:
> Select IWLWIFI_LEDS automatically when either IWL3945_LEDS or
> IWL4965_LEDS is selected. This avoids potential misconfigurations
> which lead to build failures for iwl-led.c.
>
> Cc: Miles Lane <miles.lane@xxxxxxxxx>
> Cc: reinette.chatre@xxxxxxxxx
> Signed-off-by: John w. Linville <linville@xxxxxxxxxxxxx>
> ---
> drivers/net/wireless/iwlwifi/Kconfig | 11 +++++------
> 1 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/iwlwifi/Kconfig b/drivers/net/wireless/iwlwifi/Kconfig
> index 4a5c8c0..8137690 100644
> --- a/drivers/net/wireless/iwlwifi/Kconfig
> +++ b/drivers/net/wireless/iwlwifi/Kconfig
> @@ -3,11 +3,8 @@ config IWLCORE
> depends on PCI && MAC80211 && WLAN_80211 && EXPERIMENTAL
>
> config IWLWIFI_LEDS
> - bool "Enable LEDS features in iwlwifi driver"
> - depends on IWLCORE && MAC80211_LEDS && LEDS_CLASS
> - ---help---
> - This option enables LEDS for the iwlwifi drivers
> -
> + bool
> + default n
>
> config IWLCORE_RFKILL
> boolean "IWLWIFI RF kill support"
> @@ -52,7 +49,8 @@ config IWL4965_HT
>
> config IWL4965_LEDS
> bool "Enable LEDS features in iwl4965 driver"
> - depends on IWL4965 && IWLWIFI_LEDS
> + depends on IWL4965 && MAC80211_LEDS && LEDS_CLASS
> + select IWLWIFI_LEDS
> ---help---
> This option enables LEDS for the iwlwifi drivers
>
> @@ -137,6 +135,7 @@ config IWL3945_SPECTRUM_MEASUREMENT
> config IWL3945_LEDS
> bool "Enable LEDS features in iwl3945 driver"
> depends on IWL3945 && MAC80211_LEDS && LEDS_CLASS
> + select IWLWIFI_LEDS
3945 is for now not dependent at all on this flag.
Otherwise looks OK
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/