Re: fs_stack/eCryptfs: remove 3rd arg of copy_attr_all, add lockingto copy_inode_size

From: Andrew Morton
Date: Wed Apr 02 2008 - 22:27:32 EST


On Wed, 2 Apr 2008 21:49:11 -0400 Erez Zadok <ezk@xxxxxxxxxxxxx> wrote:

> Andrew, this patch has been in my git tree for a while. It affects current
> mainline users (i.e., ecryptfs). Do you think it can go to mainline soon?
> If not, post-25? (I can remind you then). This patch has a few changes, and
> I can break it into several smaller ones if desired:
>
> 1. remove the 3rd arg to fsstack_copy_attr_all. There are no users for it:
> ecryptfs never used the 3rd arg; unionfs stopped using it a long time
> ago. Halcrow ok'ed this patch some time ago.
>
> 2. add necessary locking for 32-bit smp systems in fsstack_copy_inode_size
> (courtesy Hugh Dickins).
>
> 3. minor commenting style changes, and addition of copyrights which were
> missing.
>
> Thanks,
> Erez.
>
> --cut--here----cut--here----cut--here----cut--here----cut--here--
>
>
> fs_stack/eCryptfs: remove 3rd arg of copy_attr_all, add locking to copy_inode_size

I'm already carrying this, via git-unionfs. It makes it a bit hard to merge.
I guess resending it during the 2.6.26 merge window would suit.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/