Re: [PATCH 4 of 6] hotplug-memory: use common online_page

From: Dave Hansen
Date: Thu Apr 03 2008 - 20:48:12 EST



On Thu, 2008-04-03 at 17:05 -0700, Jeremy Fitzhardinge wrote:
> Apart from x86-32, all architectures use an identical online_page.
> Define it weakly in mm/memory_hotplug.c so that architectures can
> override it if necessary.

This is OK, but I do think the __weak stuff can make it a bit
counter-intuitive to track down which version is actually getting used.
Are there any people the currently override that __weak?

If not, we should probably just kill it.

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/