Re: [PATCH] usbcore, kernel 2.6.18.1

[Andrew Morton]

On Thu, 03 Apr 2008 15:14:54 +0200 Gerd Luyten <gluyten@xxxxxxxxx> wrote:

> This patch is to eventually detect a Velleman K8055 USB device.
> Without the patch it will fail detection with following errors:
> usb 1-2: can't read configurations, error -110
> => probably because of usb non-conformance reason of the K8055 card.
> (timing issues...)
> 
> With this patch, detection will keep on trying until usb card gets
> recognized.
> This patch adds a device reset in the "fail:" sequence instead of just
> marking the device state as NOTATTACHED.
> 
> [gluyten@workstation pup214]$ diff -u
> linux-2.6.18.1/drivers/usb/core/hub.c hub.c
> --- linux-2.6.18.1/drivers/usb/core/hub.c       2006-10-14
> 05:34:03.000000000 +0200
> +++ hub.c       2008-04-03 14:47:49.000000000 +0200
> @@ -1450,7 +1450,9 @@
>         return 0;
> 
>  fail:
> -       usb_set_device_state(udev, USB_STATE_NOTATTACHED);
> +//     usb_set_device_state(udev, USB_STATE_NOTATTACHED);
> +       usb_lock_device_for_reset(udev, NULL);
> +       usb_reset_composite_device(udev, NULL);
>         return err;
>  }
> 

2.6.18 is very old.  Does 2.6.24 (or later) also need fixing?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/