Re: [-mm] Make the memory controller more desktop responsive (v2)

From: KOSAKI Motohiro
Date: Fri Apr 04 2008 - 10:02:02 EST


Hi

> @@ -612,7 +611,7 @@ retry:
> pc->page = page;
> pc->flags = PAGE_CGROUP_FLAG_ACTIVE;
> if (ctype == MEM_CGROUP_CHARGE_TYPE_CACHE)
> - pc->flags |= PAGE_CGROUP_FLAG_CACHE;
> + pc->flags = PAGE_CGROUP_FLAG_CACHE;
>
> lock_page_cgroup(page);
> if (page_get_page_cgroup(page)) {

Yes.
in general, cache page create as cold page.
if not, large file copy or streaming file drop all cache easily.

Reviewd-by: KOSAKI
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/