Re: [PATCH] x86: create array based interface to change page attribute

From: Arjan van de Ven
Date: Mon Apr 07 2008 - 17:00:11 EST


Thomas Hellström wrote:
Ouch, so we'll be needing an ioremap_wc(), I guess. We probably shouldn't use the linear kernel map for this anyway, since that would require a chipset flush for each ring commit. We can actually use vmap() with a wc page protection for that, but an ioremap_wc() would certainly save us a lot of trouble.

please don't use vmap() as a hack for mapping IO memory when you should use ioremap_wc()....
Lets get this thing right rather than finding whichever hack of the day
happens to work with the implementation from yesterday.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/