Re: [patch 3/15] fs/logfs/logfs.h

From: Arnd Bergmann
Date: Mon Apr 07 2008 - 20:35:51 EST


On Tuesday 01 April 2008, joern@xxxxxxxxx wrote:
> +/*
> + * Private errno for accessed beyond end-of-file.  Only used internally to
> + * logfs.  If this ever gets exposed to userspace or even other parts of the
> + * kernel, it is a bug.  256 was chosen as a number sufficiently above all
> + * used errno #defines.
> + *
> + * It can be argued that this is a hack and should be replaced with something
> + * else.  My last attempt to do this failed spectacularly and there are more
> + * urgent problems that users actually care about.  This will remain for the
> + * moment.  Patches are welcome, of course.
> + */
> +#define EOF                    (512)
> +

Try to make the comment match the definition, it still says the value is 256.

Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/