Re: [PATCH] pop previous section in alternative.c

From: H. Peter Anvin
Date: Thu Apr 10 2008 - 13:58:02 EST


Linus Torvalds wrote:

Obviously, it would have been really nice if something like the assembler had caught it with some simple sanity-test (ie I think the .size thing would be a good sanity check _regardless_), so in that sense it's our bug that might have been avoided with soem sanity testing, but on the other hand, I can well understand that gas didn't do it - since it would matter only for totally buggy code that was never emitted by the compiler.


Agreed.

Gas historically used to not do any sanity-checking what-so-ever, and was very much meant to be just for compiler output (which is why #APP exists in the first place - to mark places that aren't pure compiler input). It's actually improved immensely in that area and now is useful as a traditional human-usable assembler with lots of support like macros etc.

Indeed it has.

-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/