Re: [PATCH 6/13] devres: implement managed iomap interface

From: Tejun Heo
Date: Thu Apr 10 2008 - 22:09:13 EST


Kumar Gala wrote:
but there is no reason not to make it work properly. For example I believe libata uses devm_* and the fsl SATA driver (non-PCI) will need to work in cases similar to the 44x.

Well, as for sata_fsl, it calls of_iomap() which does The Right Thing.

Fair, but I don't see why we should introduce new APIs that are already "broken". We went through a lot of effort to clean up and introduce resource_t (and clearly still have some bugs) for the >32-bit physical address problem.

Yes, please go ahead. In case it wasn't clear, I wasn't objecting to the fix at all. I was just curious what could actually happen on x86.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/