regression caused by: genirq: do not leave interupts enabled on free_irq

From: Yinghai Lu
Date: Fri Apr 11 2008 - 02:14:17 EST


last week found:
after latest kernel kexec RHEL 5.1 or other stack kernel, the nvidia
forcedeth doesn't work anymore.

I stared at forcedeth.c two days. and revert every patches about that
doesn't help.

and figure out 2.6.25-rc2 works.

with git-bisect found

commit 89d694b9dbe769ca1004e01db0ca43964806a611
Author: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Date: Mon Feb 18 18:25:17 2008 +0100

genirq: do not leave interupts enabled on free_irq

The default_disable() function was changed in commit:

76d2160147f43f982dfe881404cfde9fd0a9da21
genirq: do not mask interrupts by default

It removed the mask function in favour of the default delayed
interrupt disabling. Unfortunately this also broke the shutdown in
free_irq() when the last handler is removed from the interrupt for
those architectures which rely on the default implementations. Now we
can end up with a enabled interrupt line after the last handler was
removed, which can result in spurious interrupts.

Fix this by adding a default_shutdown function, which is only
installed, when the irqchip implementation does provide neither a
shutdown nor a disable function.

[@stable: affected versions: .21 - .24 ]

Pointed-out-by: Michael Hennerich <Michael.Hennerich@xxxxxxxxxx>
Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Acked-by: Ingo Molnar <mingo@xxxxxxx>
Cc: stable@xxxxxxxxxx
Tested-by: Michael Hennerich <Michael.Hennerich@xxxxxxxxxx>

caused the regression.

it affected all my servers that are using Nvidia MCP55.

maybe we need to revert that patch.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/