Re: [PATCH] GPIO: #include <linux/kernel.h> for might_sleep

From: Uwe Kleine-König
Date: Fri Apr 11 2008 - 06:47:04 EST


Hello again,

Uwe Kleine-König wrote:
> Signed-off-by: Uwe Kleine-König <Uwe.Kleine-Koenig@xxxxxxxx>
> ---
> Hello David,
>
> I like having headers being independend of the order of inclusion.
> Usually I order all includes alphabetically (and grouped by linux/,
> asm/, etc.). This doesn't work with gpio.h because then kernel.h is
> included to late.
I just noticed that you need include/asm/types.h also for the
CONFIG_HAVE_GPIO_LIB=y case. So the #include can better go to the top
of include/asm-generic/gpio.h.

I won't send a new version untill you say if it's OK for you to add
#includes to that header.

Best regards
Uwe

--
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/