[RFC] x86: Cleanup prose of Documentation/i386/IO-APIC.txt

From: Nick Andrew
Date: Fri Apr 11 2008 - 11:41:17 EST


I'm doing a couple of cleanups to Documentation/i386/IO-APIC.txt
and I have a problem with this line, which is supposed to compute
a sample pirq= kernel parameter:

echo -n pirq=; echo `scanpci | grep T_L | cut -c56-` | sed 's/ /,/g'

The 'scanpci' command used to be part of xutils and/or XFree86.
Xorg implements "Xorg -scanpci" but the output is different and it won't
run while X is running.

Firstly I propose using the $( ) construct rather than backticks, since
it is easier to read:

echo -n pirq=; echo $( scanpci | grep T_L | cut -c56- ) | sed 's/ /,/g'

Inside the backtics, instead of scanpci, I could do:

lspci -v | grep IRQ | sed -e 's/.* IRQ \(\w\+\)/\1/'

Is this an acceptable substitution?

Nick.
--
PGP Key ID = 0x418487E7 http://www.nick-andrew.net/
PGP Key fingerprint = B3ED 6894 8E49 1770 C24A 67E3 6266 6EB9 4184 87E7
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/