Re: [PATCH 34/35] W1: Documentation/w1/masters/ds2490 update

[David Fries]

On Sun, Mar 30, 2008 at 03:43:35PM +0400, Evgeniy Polyakov wrote:
> On Fri, Mar 28, 2008 at 07:27:59AM -0500, David Fries (david@xxxxxxxxx) wrote:
> > +Notes and limitations.
> > +- The 5V strong pullup is supported.
> > +- While the ds2490 supports a hardware search the code doesn't take
> > +  advantage of it.
> 
> It does not actually - at least my hardware can only find first device
> on the bus, so I dropped the implementation.

ds_search, ds_match_access, and ds_set_path need a comment to that
effect then.

> I generally ack whe whole ds2490 changes except pullup one - it has
> to be turned off by default, presumably tested with multiple devices on
> the same wire.

The second set of patches include a module parameter for both the
w1_therm where a 5V strong pullup is requested and the one wire core
w1_io.c where the request makes calls into the master driver.  This
way there is also a sysfs file to enable and disable the 5V strong
pullup per master.

I have tested the 5V strong pullup with five devices on the bus.  It
works fine.  Two ds18b20 temperature sensors and two thermochron
iButton sensors.  I have maybe 20 feet of wire with a fork near the
ds2490.

It is the 12V programming pulse that is limited to one device and a
shorter wire.  This is the 5V strong pullup, and it doesn't have any
cautions.  The data wire is already working at 5V, it is just the
amount of current that can be supplied increases.

While I agree it is good to have an option to disable it, as it is
optional, what is your reasoning to opposed it?  The ds2490
specification describes in the active pullup section that when the bus
is low and the desired state is high it will start first by the weak
pullup, then when the voltage reaches 0.25V it will switch on the
strong pullup, and VD-1.75V to VDD -0.3V it will set a timer to
disable the strong pullup.  So it is already being used on the bus.

> David, thanks a lot for your work on w1 drivers.
> 
> -- 
> 	Evgeniy Polyakov

-- 
David Fries <david@xxxxxxxxx>
http://fries.net/~david/ (PGP encryption key available)

Attachment: pgp00000.pgp
Description: PGP signature