Re: [PATCH 1/3] PM: Introduce new top level suspend and hibernation callbacks (rev. 8)

From: Pavel Machek
Date: Mon Apr 14 2008 - 06:55:41 EST


On Mon 2008-04-14 08:47:02, Benjamin Herrenschmidt wrote:
>
> > Well, I'm not sure and I'm not going to introduce the change right now, after
> > the paches have been included in -mm.
> >
> > That would require quite some changes in the core code that I'd prefer to
> > avoid for now. We can do something like this in a separate patch series after
> > the present one settles down a bit.
>
> I disagree.
>
> Doing it later would introduce yet another major semantic change.

'allow load_firmware from prepare that was not allowed before' is not 'major'.

If you feel strongly about that, please prepare patch at the top of
Rafael's and we can discuss it.

But it really should be separate patch.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/