Re: Pageflags: Standardize comment inclusion in asm-offsets.h and fix MIPS

From: Sam Ravnborg
Date: Mon Apr 14 2008 - 16:58:27 EST


On Mon, Apr 14, 2008 at 11:43:08AM -0700, Christoph Lameter wrote:
> Add the ability to pass comments into asm-offsets.h by generating asm
> output like
>
> -># comment line
>
> Mips needs this feature to preserve the comments that are in asm-mips/asm-offsets.h
> right now.
>
> Then remove the special handling for mips from Kbuild and convert mips to use
> the new string to include the comments.
>
> Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
> Signed-off-by: Christoph Lameter <clameter@xxxxxxx>

My sedfu is not enough to properly review this.
And I am not yet able to test it.

But the general principle is good and I really like to see mips
aligned with the rest!

Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/