Re: [PATCH] use vmalloc for mem_cgroup allocation.

[KAMEZAWA Hiroyuki]

On Tue, 15 Apr 2008 09:57:17 +0800
Li Zefan <lizf@xxxxxxxxxxxxxx> wrote:

> >  #include <asm/uaccess.h>
> >  
> > @@ -993,7 +994,7 @@ mem_cgroup_create(struct cgroup_subsys *
> >  		mem = &init_mem_cgroup;
> >  		page_cgroup_cache = KMEM_CACHE(page_cgroup, SLAB_PANIC);
> >  	} else
> > -		mem = kzalloc(sizeof(struct mem_cgroup), GFP_KERNEL);
> > +		mem = vmalloc(sizeof(struct mem_cgroup));
> >  
> 
> memset(mem, 0, sizeof(*mem));
> 
ok, will rewrite.

> should we initialize it with 0?
> 
yes. (at least, per-cpu stat. mem->css, per-node pointer, ... should be zero.)

Thanks,
-Kame


> >  	if (mem == NULL)
> >  		return ERR_PTR(-ENOMEM);
> > @@ -1011,7 +1012,7 @@ free_out:
> >  	for_each_node_state(node, N_POSSIBLE)
> >  		free_mem_cgroup_per_zone_info(mem, node);
> >  	if (cont->parent != NULL)
> > -		kfree(mem);
> > +		vfree(mem);
> >  	return ERR_PTR(-ENOMEM);
> >  }
> >  
> > @@ -1031,7 +1032,7 @@ static void mem_cgroup_destroy(struct cg
> >  	for_each_node_state(node, N_POSSIBLE)
> >  		free_mem_cgroup_per_zone_info(mem, node);
> >  
> > -	kfree(mem_cgroup_from_cont(cont));
> > +	vfree(mem_cgroup_from_cont(cont));
> >  }
> >  
> >  static int mem_cgroup_populate(struct cgroup_subsys *ss,
> > 
> >
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/