[PATCH 2/6] MIPS: ip27-timer: fix unsigned irq < 0

From: Roel Kluin
Date: Tue Apr 15 2008 - 21:44:15 EST


irq is unsigned, cast to signed to evaluate the allocate_irqno() return value,

Signed-off-by: Roel Kluin <12o3l@xxxxxxxxxx>
---
diff --git a/arch/mips/sgi-ip27/ip27-timer.c b/arch/mips/sgi-ip27/ip27-timer.c
index 25d3baf..3c08afd 100644
--- a/arch/mips/sgi-ip27/ip27-timer.c
+++ b/arch/mips/sgi-ip27/ip27-timer.c
@@ -222,19 +222,19 @@ static void __init hub_rt_clock_event_global_init(void)
unsigned int irq;

do {
smp_wmb();
irq = rt_timer_irq;
if (irq)
break;

irq = allocate_irqno();
- if (irq < 0)
+ if ((int) irq < 0)
panic("Allocation of irq number for timer failed");
} while (xchg(&rt_timer_irq, irq));

set_irq_chip_and_handler(irq, &rt_irq_type, handle_percpu_irq);
setup_irq(irq, &hub_rt_irqaction);
}

static cycle_t hub_rt_read(void)
{
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/