Re: hci_usb: remove macro code obfuscation

[Pavel Machek]

On Wed 2008-04-16 13:51:37, Vitaliy Ivanov wrote:
> On Wed, Apr 16, 2008 at 1:42 PM, Pavel Machek <pavel@xxxxxx> wrote:
> >
> >  I had trouble figuring out what the code does. atomic_inc/dec
> >  management is actually pretty simple, but it is needlessly obfuscated
> >  with macros. Fix that.
> >
> >  Signed-off-by: Pavel Machek <pavel@xxxxxxx>
> >
> >  I had trouble figuring out what the code does. atomic_inc/dec
> >  management is actually pretty simple, but it is needlessly obfuscated
> >  with macros. Fix that.
> >
> >  Signed-off-by: Pavel Machek <pavel@xxxxxxx>
> 
> 
> Got it from the first time;)
> 
> Do you think that now code looks better? As for me it's not...

Yes. Hiding & operator deep inside macro is evil for one thing. Plus
it is no longer clear what the code does with the macros in there.
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/